MAINT: Reenable parallel write safety #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
changed the title
drammock
approved these changes
Jun 4, 2024
Is there a reference for this somewhere? It triggered under pretty innocent-looking circumstances, so it'd be a pity IMO to have no mechanism in place to diagnose, or at least a sphinx issue to refer to. |
|
Yep, just took me a while to write up! |
|
Thanks for digging into this issue across scipy/PST/sphinx! 🙏 |
Closed
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scipy/scipy#20897. TL;DR is that the problem was always with reading in parallel, not writing. And the bug is really in Sphinx.
It would be good to detect and clean this up in PST somehow perhaps as well -- maybe with a warning if a top-level / root page ever shows up as a child? This might only be an issue when building in parallel, still not totally clear to me why things were okay in the serial case.
I think any additional changes could be made in a follow-up PR probably.
closes #1643