Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolder bigger headings #1983

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented Sep 12, 2024

This PR:

Closes Quansight-Labs/czi-scientific-python-mgmt#97.

Before/after screenshots

Before After

Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

@trallard trallard added tag: CSS CSS and SCSS related issues tag: accessibility Issues related to accessibility issues or efforts labels Sep 18, 2024
@trallard
Copy link
Collaborator

Thank you @gabalafou this all looks good to me so have approved this PR and unless there are objections in the next couple of days I will merge right then

@trallard trallard merged commit 7ebc87e into pydata:main Sep 19, 2024
25 checks passed
gabalafou added a commit to gabalafou/pydata-sphinx-theme that referenced this pull request Oct 6, 2024
This PR:

- Increases heading (h1, h2, h3, etc) font weight from 400 to 600
  - Why? To make headings stand out better from the body text
- Increases h1 and h2 font size, slightly decreases h6 size
- Why? Brings the headings into better alignment with standard
typographic scales. See
Quansight-Labs/czi-scientific-python-mgmt#97.

Closes
Quansight-Labs/czi-scientific-python-mgmt#97.

### Before/after screenshots

| Before | After |
| ---- | ---- |
|
![](https://github.com/user-attachments/assets/a5be530a-f7c9-4b13-a580-e28b0340c3cd)
|
![](https://github.com/user-attachments/assets/6dc8cad8-f325-47bc-bd45-25259df8ec16)
|
@Carreau Carreau added this to the Empty milestone. milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: CSS CSS and SCSS related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H2 and H3 headings too similar visually
5 participants