Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Higher contrast table hover stripe (light mode) #2062

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Higher contrast table hover stripe (light mode) #2062

merged 2 commits into from
Dec 3, 2024

Conversation

gabalafou
Copy link
Collaborator

@gabalafou gabalafou commented Nov 30, 2024 •
edited
Loading

This pull request:

  • changes the background hover color on tables to improve legibility
  • differs from the design system, but I think it looks better, plus it steps up the hover background/foreground contrast in light mode to meet WCAG AAA.

Note: once #2059 is merged, this will only affect .dataframe classes

After screenshot


Before screenshot

@gabalafou gabalafou requested a review from trallard November 30, 2024 20:01
@gabalafou
Copy link
Collaborator Author

@smeragoel, 👍 ? 👎 ?

@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

drammock
drammock previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will defer to @smeragoel

@trallard trallard added tag: design Items related to design tasks or improvements tag: accessibility Issues related to accessibility issues or efforts labels Dec 3, 2024
trallard
trallard previously approved these changes Dec 3, 2024
View reviewed changes
@smeragoel
Copy link
Contributor

I agree, this definitely looks better. No objections to this change, however, we should also make a symmetric change for dark mode as well to ensure consistency in light / dark mode color patterns.

light mode: 300 -> 200
dark mode: 600 -> 700

@gabalafou gabalafou dismissed stale reviews from trallard and drammock via 8aae01e December 3, 2024 14:56
@gabalafou
Copy link
Collaborator Author

Thanks @smeragoel, I've updated the pull request with your suggestion and added screenshots to the description.

@drammock drammock merged commit 6cc8ddf into pydata:main Dec 3, 2024
25 checks passed
@gabalafou gabalafou deleted the lighter-hover-stripe-light branch December 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drammock drammock drammock approved these changes

@trallard trallard trallard left review comments

Assignees
No one assigned
Labels
tag: accessibility Issues related to accessibility issues or efforts tag: design Items related to design tasks or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabalafou @smeragoel @drammock @trallard