TEST: Basic test for our switcher #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple regression test for our switcher templating code, to make sure that the HTML structure it generates doesn't change over time.
It does not test all of the switcher's behavior (since this requires JavaScript), but includes a note about this so that it's clear for others what we are / aren't testing.
I added this because in reading through #576 I wanted to ask for a test, but then realized there were no tests at all for this, and when I tried to implement one, realized that it was more complicated because of the JavaScript dependency. This PR makes this explicit so that others don't have to go through the same confusion. As an extra benefit, we test for the basic structure of our HTML template, so we'll catch something if that changes.