ENH: Add section title to sidebar navigation #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12rambau
reviewed
Aug 28, 2022
src/pydata_sphinx_theme/theme/pydata_sphinx_theme/components/navbar-nav.html
Show resolved
Hide resolved
|
Agree re: extra whitespace for the version switcher. Want to propose something you think makes it look better? |
I was not able to open a PR on your branch (I don't know why it wasn't working) but as it's a minimal change I took the liberty of pushing it. Feel free to modify everything if needed |
|
No problem @12rambau you are always welcome to push directly to my branches in a PR! |
choldgraf
commented
Aug 28, 2022
src/pydata_sphinx_theme/assets/styles/components/_switcher-version.scss
Outdated
Show resolved
Hide resolved
|
I think this is ready to go. The failing test is because of the pandas pre-release job failing but not related to this PR. I opened an issue to suggest a path forward here: |
jarrodmillman
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some of our sidebar navigation code, so that it is structured more compactly in our theme, and so that there are similar navigation headers for both the site and section navigation. Here's a quick summary:
Site Navigationtitle to be inside of oursite header navigationcomponent. This is invisible in widescreen, but is visible on narrow screens when it shows up in the sidebar.Section Navigationtitle to the "within section" navigation, so it's easy to distinguish the site/section navigation.For example, note the "site navigation" and (new) "section navigation" headers: