-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for legacy Python 2.7 #235
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 97.63% 97.71% +0.08%
==========================================
Files 11 10 -1
Lines 1564 1532 -32
==========================================
- Hits 1527 1497 -30
+ Misses 37 35 -2
Continue to review full report at Codecov.
|
This pull request fixes 4 alerts when merging 6969cd5 into 4b262fb - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks! Let me know when you’re done and I’ll merge.
Could you also add testing for 3.7? |
@@ -8,6 +8,8 @@ matrix: | |||
- python: 3.5 | |||
env: NUMPY_VERSION="<1.14.0" | |||
- python: 3.6 | |||
- python: 3.7 | |||
dist: xenial |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware that you needed this, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see travis-ci/travis-ci#9069 / travis-ci/travis-ci#9815 for details (sudo
is no longer needed).
I don't mean to ask for too much, but it seems like there are |
Maybe pyupgrade only replaces |
Understood, I'll merge once the last check passes. |
This pull request fixes 4 alerts when merging ce5b2c6 into 4b262fb - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
Merging, thanks a lot, @hugovk! |
upstream dropped support pydata/sparse#235
Fixes #234.
And upgrade Python syntax using https://github.com/asottile/pyupgrade.