Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for legacy Python 2.7 #235

Merged
merged 8 commits into from
Mar 1, 2019
Merged

Drop support for legacy Python 2.7 #235

merged 8 commits into from
Mar 1, 2019

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 28, 2019

Fixes #234.

And upgrade Python syntax using https://github.com/asottile/pyupgrade.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #235 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   97.63%   97.71%   +0.08%     
==========================================
  Files          11       10       -1     
  Lines        1564     1532      -32     
==========================================
- Hits         1527     1497      -30     
+ Misses         37       35       -2
Impacted Files Coverage Δ
sparse/sparse_array.py 97.22% <100%> (-0.34%) ⬇️
sparse/slicing.py 99.2% <100%> (-0.02%) ⬇️
sparse/coo/umath.py 97.13% <100%> (ø) ⬆️
sparse/coo/core.py 96.7% <100%> (-0.04%) ⬇️
sparse/dok.py 95.53% <100%> (-0.04%) ⬇️
sparse/coo/indexing.py 99.18% <100%> (ø) ⬆️
sparse/utils.py 100% <100%> (ø) ⬆️
sparse/coo/common.py 98.1% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b262fb...ce5b2c6. Read the comment docs.

@hameerabbasi
Copy link
Collaborator

This pull request fixes 4 alerts when merging 6969cd5 into 4b262fb - view on LGTM.com

fixed alerts:

  • 4 for Unused import

Comment posted by LGTM.com

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! Let me know when you’re done and I’ll merge.

@hameerabbasi
Copy link
Collaborator

Could you also add testing for 3.7?

@@ -8,6 +8,8 @@ matrix:
- python: 3.5
env: NUMPY_VERSION="<1.14.0"
- python: 3.6
- python: 3.7
dist: xenial
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware that you needed this, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see travis-ci/travis-ci#9069 / travis-ci/travis-ci#9815 for details (sudo is no longer needed).

@hameerabbasi
Copy link
Collaborator

I don't mean to ask for too much, but it seems like there are %-strings in the code for a while now. Is there a way to automatically replace those? (According to the pyupgrade docs, --py3-plus should have done it).

@hugovk
Copy link
Contributor Author

hugovk commented Mar 1, 2019

Maybe pyupgrade only replaces % formatters on explicit strings.

@hameerabbasi
Copy link
Collaborator

Understood, I'll merge once the last check passes.

@hameerabbasi
Copy link
Collaborator

This pull request fixes 4 alerts when merging ce5b2c6 into 4b262fb - view on LGTM.com

fixed alerts:

  • 4 for Unused import

Comment posted by LGTM.com

@hameerabbasi
Copy link
Collaborator

Merging, thanks a lot, @hugovk!

@hameerabbasi hameerabbasi merged commit 257da2c into pydata:master Mar 1, 2019
risicle added a commit to risicle/nixpkgs that referenced this pull request Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants