Avoid making a copy of coords
#296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coords is not modified anywhere in this class, so we probably do not need to copy it. This also would allow for identity short-cuts when performing operations on sparse arrays with the same sparsity pattern.
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 15 15
Lines 2036 2036
=======================================
Hits 1899 1899
Misses 137 137 |
hameerabbasi
approved these changes
Oct 17, 2019
|
Thanks, @eric-wieser! |
|
Worth noting that bad things could happen if anyone is doing something that mutates coords = np.zeros((3, 200), np.intp)
s = COO(coords=coords, ...)
coords[...] = 0 # !!!This doesn't seem particularly likely though, and the following was already not ok anyway: coords = np.zeros((3, 200), np.intp)
s = COO(coords=coords, ...)
s.coords[...] = 0 # !!! |
|
Yes, we don't follow that pattern anywhere in our code, and I'm fairly sure others don't either. Anyway, thanks for noting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coords is not modified anywhere in this class, so we probably do not need to copy it.
This also would allow for identity short-cuts when performing operations on sparse arrays with the same sparsity pattern.