Update docs for GCXS and CSR/CSC #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm seeing that I should update index.rst as well. I'll make a commit for that and if you think it's good we can merge after that. |
|
@hameerabbasi, thanks for reviewing. Let me know if this looks good to you. |
performance comment fix title underline
format header
hameerabbasi
requested changes
Apr 2, 2021
There was a problem hiding this comment.
This should be the last comment. Thanks so much for all the hard work, @daletovar!
docs/index.rst
Outdated
| and depends on scipy.sparse for some computations. | ||
| The data structures in pydata/sparse complement and can | ||
| be used in conjunction with the fast linear algebra routines | ||
| inside scipy.sparse. |
There was a problem hiding this comment.
I'd mention here that a conversion or a copy may be required.
|
Thanks so much, @hameerabbasi. How does this look? |
hameerabbasi
approved these changes
Apr 2, 2021
|
Thanks, @daletovar! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GCXS to operations.rst and adds GCXS and CSR/CSC to the completed tasks section of the roadmap.