Preserve gcxs compression #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 90.42% 90.43% +0.01%
==========================================
Files 20 20
Lines 3560 3564 +4
==========================================
+ Hits 3219 3223 +4
Misses 341 341 |
|
@jamestwebber do you mind if we land #599 first? Should be done by tomorrow. |
|
Yeah no rush here!
…On Sun, Jul 2, 2023, 15:11 Hameer Abbasi ***@***.***> wrote:
@jamestwebber <https://github.com/jamestwebber> do you mind if we land
#599 <#599> first? Should be done by
tomorrow.
—
Reply to this email directly, view it on GitHub
<#601 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHLIP2Q37FF2HIJ2I5ZBK3XOHBXNANCNFSM6AAAAAAZ3RQ4XA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jamestwebber |
jamestwebber
force-pushed
the
preserve-gcxs-compression
branch
from
683b2b8 to
0d04116
Compare
|
Thanks for your patience and work on this, @jamestwebber! |
|
One thing I didn't do is add a test for regression. "when I have time" 😂 I will open a new PR with a fast unary path and I can add tests then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #596 in a fairly simple way: if all of the inputs are GCXS arrays and they have the same compression, it will return the output with the same compression. I just do this by storing a
kwargsdictionary during the_Elemwiseinitialization.A further enhancement that I'm exploring: if the
ufunchas a single input, we could avoid the conversion toCOOentirely, as well as skip some other checks. In this case we know that our argument is sparse (or we wouldn't be creating this class) and we know that it "broadcasts" to the same shape. The things to consider are the potential keywords for the ufunc:where,out, etc.