-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use matrepr for rich __str__
and _repr_html_
#605
Conversation
If available, use the matrepr package to render array values in string and HTML output. Reverts to current behavior if matrepr is not installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fairly minimal and self-contained. Thanks!
I'll take a look at the CI later today. |
I see a few other recent PRs with the same fail. The message is right, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 92.15% 91.95% -0.21%
==========================================
Files 20 20
Lines 3313 3330 +17
==========================================
+ Hits 3053 3062 +9
- Misses 260 268 +8 |
The test fails were from the linter, I implemented its suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
If available, use the matrepr package to render array values in string and HTML output.
Reverts to current behavior if matrepr is not installed.
See this Jupyter notebook for a demo of what 1D, 2D, and 3D sparse arrays look like when rendered by matrepr.
Closes #604