API: Refactor argmax and argmin
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 91.55% 90.86% -0.69%
==========================================
Files 20 20
Lines 3516 3546 +30
==========================================
+ Hits 3219 3222 +3
- Misses 297 324 +27 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I think the comments from the GitHub bot are valid in this PR and should be addressed. |
mtsokol
force-pushed
the
new-argmax-argmin
branch
from
4f56751 to
cae0fe7
Compare
Hi @hameerabbasi, |
|
Thanks for your awesome work on this @mtsokol. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hameerabbasi,
This PR refactors the current implementation of
argmaxandargmin. It removes "only 0.0 fill value" and "all non-fill values greater/less than the fill value" constraints. It also makes the core of the function jittable.First #613 needs to be merged.