Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Improve sparse.asarray #615

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Jan 2, 2024

Hi @hameerabbasi,

This PR refines sparse.asarray by including original dtype of the passed array.
It also adds __array_namespace__, __array_api_version__ (Array API compatibility), and some minor improvements.

@mtsokol mtsokol self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Merging #615 (215bca6) into master (b12d51d) will decrease coverage by 0.24%.
The diff coverage is 58.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
- Coverage   90.86%   90.62%   -0.24%     
==========================================
  Files          20       20              
  Lines        3546     3563      +17     
==========================================
+ Hits         3222     3229       +7     
- Misses        324      334      +10     

sparse/_coo/common.py Dismissed Show dismissed Hide dismissed
@hameerabbasi hameerabbasi merged commit 492c279 into pydata:master Jan 2, 2024
12 of 13 checks passed
@hameerabbasi
Copy link
Collaborator

Thanks,  @mtsokol!

@mtsokol mtsokol deleted the refine-asarray branch January 2, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants