API: Add sort and take functions for COO format
#627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
- Coverage 90.57% 90.20% -0.38%
==========================================
Files 20 20
Lines 3618 3654 +36
==========================================
+ Hits 3277 3296 +19
- Misses 341 358 +17 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mtsokol
force-pushed
the
sparse-sort-and-take
branch
from
33da5ff to
ff2084f
Compare
hameerabbasi
requested changes
Jan 16, 2024
mtsokol
force-pushed
the
sparse-sort-and-take
branch
from
6d0591a to
1b5662d
Compare
mtsokol
force-pushed
the
sparse-sort-and-take
branch
2 times, most recently
from
9360efc to
af4ea95
Compare
hameerabbasi
requested changes
Jan 16, 2024
mtsokol
force-pushed
the
sparse-sort-and-take
branch
from
af4ea95 to
16cbe86
Compare
for more information, see https://pre-commit.ci
|
Ok, I think I addressed all comments - the PR is ready for another review. |
hameerabbasi
approved these changes
Jan 16, 2024
Thanks! Unfortunately I see: "You’re not authorized to merge this pull request." |
What about now? |
|
Merged! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @hameerabbasi,
This PR adds
sortandtakeArray API functions for the COO format to the main namespace.sortfunction, where looping happens, is numba jitted.