Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for scipy.sparse.csgraph and scipy.sparse.linalg #683

Merged
merged 3 commits into from
May 21, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented May 21, 2024

Hi @hameerabbasi,

Here's a PR that contains:

@mtsokol mtsokol requested a review from hameerabbasi May 21, 2024 12:01
@mtsokol mtsokol self-assigned this May 21, 2024
Copy link

github-actions bot commented May 21, 2024

Test Results

5 991 tests  +68   5 932 ✅ +40   9m 32s ⏱️ -11s
    1 suites ± 0      59 💤 +28 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 1839415. ± Comparison against base commit 554cc7b.

This pull request removes 8 and adds 76 tests. Note that renamed tests count towards both.
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-C]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-coo-F]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-csc-F]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Finch-csr-C]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Numba-coo-C]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Numba-coo-F]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Numba-csc-F]
sparse.tests.test_backends ‑ test_scipy_sparse_dispatch[BackendType.Numba-csr-C]
sparse.tests.test_backends ‑ test_scikit_learn_dispatch[BackendType.Finch-csc_matrix-csc-F]
sparse.tests.test_backends ‑ test_scikit_learn_dispatch[BackendType.Numba-csc_matrix-csc-F]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Finch-coo_matrix-coo-F]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Finch-csc_matrix-csc-F]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Finch-csr_matrix-csr-C]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Numba-coo_matrix-coo-F]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Numba-csc_matrix-csc-F]
sparse.tests.test_backends ‑ test_scipy_breadth_first_tree[BackendType.Numba-csr_matrix-csr-C]
sparse.tests.test_backends ‑ test_scipy_connected_components[BackendType.Finch-coo_matrix-coo-F]
sparse.tests.test_backends ‑ test_scipy_connected_components[BackendType.Finch-csc_matrix-csc-F]
…
This pull request skips 3 and un-skips 1 tests.
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.numba_backend.tests.test_compressed ‑ test_reductions_float16[f8-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[f4-None-sum-kwargs0]
sparse.numba_backend.tests.test_coo ‑ test_reductions_float16[i4-axis4-mean-kwargs1]

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here, @mtsokol! I've left some comments, mostly that the tests should be parametrized over function.

You can use a module-level PyTest fixture if you don't want to create the arrays over and over again.

@hameerabbasi
Copy link
Collaborator

Thanks for working on this @mtsokol!

@hameerabbasi hameerabbasi merged commit b0f1a81 into main May 21, 2024
13 checks passed
@hameerabbasi hameerabbasi deleted the scipy-dispatch branch May 21, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants