-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for scipy.sparse.csgraph
and scipy.sparse.linalg
#683
Conversation
Test Results5 991 tests +68 5 932 ✅ +40 9m 32s ⏱️ -11s Results for commit 1839415. ± Comparison against base commit 554cc7b. This pull request removes 8 and adds 76 tests. Note that renamed tests count towards both.
This pull request skips 3 and un-skips 1 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here, @mtsokol! I've left some comments, mostly that the tests should be parametrized over function.
You can use a module-level PyTest fixture if you don't want to create the arrays over and over again.
Thanks for working on this @mtsokol! |
Hi @hameerabbasi,
Here's a PR that contains:
test_unary[sign((x_i is -0 or x_i == +0)) -> 0]
to skips as this test is now flaky (it correctly failed in the PR but I see in the main branch it succeeded causing XPASS, so I guess--derandomize
didn't get rid of all randomness)test_scipy_sparse_csgraph_dispatch
withscipy.sparse.csgraph
testsnorm
,eigs
, andlsqr
topydata/sparse
input scipy/scipy#20759 (and a new scipy release)test_scikit_learn_dispatch
, skipped for now as it requires Add automatic conversion frompydata/sparse
to scipy sparse counterparts scikit-learn/scikit-learn#29031