-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Adding release drafter #719
Conversation
for more information, see https://pre-commit.ci
@hameerabbasi when I added this to Narwhals, there was the same error. That is because, like I mentioned above, the files normally should be added to the repo without a PR. I think it should be merged like that. |
Can we force people to have proper PR titles? |
I need to do find out how to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the discussion on Slack, let's update CONTRIBUTING.md
to include instructions for how to properly write PR titles.
Looks like my cat likes adding unnecessary labels. 😅 |
Added to |
for more information, see https://pre-commit.ci
I added instructions on release-procedure.md.
If there are more PRs that need to be ignored, we need to make sure they are skipped. |
Let's leave this to a follow-up and get this in. |
The release drafter will classify new PRs according to their title (if the title is correctly written).
The PRs titles can be manually corrected and the drafter will classify them (even if they are closed).
Please notice that once the auto-label is set, the release drafter doesn't change it.
I think that there is no way to test these files before merging. The reason being that these files are supposed to be added directly to the repository on GitHub, not through a PR. (But I tested them on my own "toy" project and I also added them on the Narwhals project).
The label names/classifications were heavily inspired (copied) from polars' repo. I can change them if needed.