Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Adding release drafter #719

Merged
merged 10 commits into from
Jul 25, 2024
Merged

ci: Adding release drafter #719

merged 10 commits into from
Jul 25, 2024

Conversation

DeaMariaLeon
Copy link
Collaborator

@DeaMariaLeon DeaMariaLeon commented Jul 22, 2024

The release drafter will classify new PRs according to their title (if the title is correctly written).
The PRs titles can be manually corrected and the drafter will classify them (even if they are closed).
Please notice that once the auto-label is set, the release drafter doesn't change it.

I think that there is no way to test these files before merging. The reason being that these files are supposed to be added directly to the repository on GitHub, not through a PR. (But I tested them on my own "toy" project and I also added them on the Narwhals project).

The label names/classifications were heavily inspired (copied) from polars' repo. I can change them if needed.

@DeaMariaLeon
Copy link
Collaborator Author

@hameerabbasi when I added this to Narwhals, there was the same error. That is because, like I mentioned above, the files normally should be added to the repo without a PR.

I think it should be merged like that.

@hameerabbasi
Copy link
Collaborator

Can we force people to have proper PR titles?

@DeaMariaLeon
Copy link
Collaborator Author

I need to do find out how to do that.

@hameerabbasi hameerabbasi enabled auto-merge (squash) July 23, 2024 05:23
@hameerabbasi hameerabbasi disabled auto-merge July 23, 2024 05:24
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the discussion on Slack, let's update CONTRIBUTING.md to include instructions for how to properly write PR titles.

@hameerabbasi
Copy link
Collaborator

Looks like my cat likes adding unnecessary labels. 😅

@DeaMariaLeon
Copy link
Collaborator Author

DeaMariaLeon commented Jul 23, 2024

Added to contributing.md. What do you think?
edit:
Maybe we can add a note (of the PR title) on the PR template as well.

@DeaMariaLeon
Copy link
Collaborator Author

DeaMariaLeon commented Jul 24, 2024

I added instructions on release-procedure.md.
Added also this to .github.release-drafter.yml so the PRs opened by the pre-commit are ignored by the drafter:

- label: 'skip changelog'
    title:
      - '/^\[pre-commit.ci\]/'

If there are more PRs that need to be ignored, we need to make sure they are skipped.

@hameerabbasi
Copy link
Collaborator

Maybe we can add a note (of the PR title) on the PR template as well.

Let's leave this to a follow-up and get this in.

@hameerabbasi hameerabbasi enabled auto-merge (squash) July 25, 2024 05:20
@hameerabbasi hameerabbasi merged commit a09268f into pydata:main Jul 25, 2024
15 of 17 checks passed
@DeaMariaLeon DeaMariaLeon deleted the changelog branch July 25, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants