Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added docstring for COO.mT #722

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

DeaMariaLeon
Copy link
Collaborator

Could you please tell me if the docstrings should be like this?

Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but everything else LGTM.

One comment: I'd copy the descriptions from the Array API docs as much as I can.

mkdocs.yml Outdated Show resolved Hide resolved
docs/operations.md Show resolved Hide resolved
sparse/numba_backend/_coo/core.py Outdated Show resolved Hide resolved
@hameerabbasi hameerabbasi enabled auto-merge (squash) July 23, 2024 07:04
@DeaMariaLeon
Copy link
Collaborator Author

I'd copy the descriptions from the Array API docs as much as I can.

I changed the description then.

I think I addressed the rest of the comments too. Please let me know if something else is needed.

@hameerabbasi
Copy link
Collaborator

hameerabbasi commented Jul 23, 2024

Thanks for the work on this @DeaMariaLeon! This should merge once required CI passes.

@hameerabbasi hameerabbasi merged commit 18079ea into pydata:main Jul 23, 2024
15 of 16 checks passed
@DeaMariaLeon DeaMariaLeon deleted the example branch July 23, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants