Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add sparse_vector constructor #791

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Oct 14, 2024

Hi @hameerabbasi,

I started porting Array API vecdot function to Finch MLIR backend. So far it's 1D only so here's a SparseVector format that is needed for it.

@mtsokol mtsokol added the enhancement Indicates new feature requests label Oct 14, 2024
@mtsokol mtsokol requested a review from hameerabbasi October 14, 2024 13:10
@mtsokol mtsokol self-assigned this Oct 14, 2024
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm working on a more defined way of putting together levels and ops in a lazy fashion.

@hameerabbasi hameerabbasi merged commit d770f66 into main Oct 14, 2024
16 checks passed
@hameerabbasi hameerabbasi deleted the sparse-vector-format branch October 14, 2024 13:27
Copy link

codspeed-hq bot commented Oct 14, 2024

CodSpeed Performance Report

Merging #791 will degrade performances by 52.34%

Comparing sparse-vector-format (7314e1e) with main (9067817)

Summary

❌ 1 regressions
✅ 339 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sparse-vector-format Change
test_index_fancy[side=100-rank=1-format='coo'] 675.5 µs 1,417.2 µs -52.34%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants