Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Revert micromamba version to v2 #805

Merged
merged 1 commit into from
Nov 26, 2024
Merged

BLD: Revert micromamba version to v2 #805

merged 1 commit into from
Nov 26, 2024

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Nov 7, 2024

This PR reverts CI change introduced in #799.

@mtsokol mtsokol self-assigned this Nov 7, 2024
@hameerabbasi hameerabbasi enabled auto-merge (squash) November 7, 2024 11:03
@mtsokol
Copy link
Collaborator Author

mtsokol commented Nov 7, 2024

I think we should merge it once windows job passes, so when mamba-org/setup-micromamba#227 is fixed. WDYT?

@hameerabbasi
Copy link
Collaborator

I think we should merge it once windows job passes, so when mamba-org/setup-micromamba#227 is fixed. WDYT?

SGTM, can't merge it until CI passes anyway. So my recommendation would be to re-run the CI and then merge after a fix.

@mtsokol mtsokol added the build label Nov 7, 2024
Copy link

codspeed-hq bot commented Nov 7, 2024

CodSpeed Performance Report

Merging #805 will degrade performances by 34.38%

Comparing micromamba-v2 (fda977f) with main (c0b2b45)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main micromamba-v2 Change
test_index_slice[side=100-rank=2-format='gcxs'] 2.4 ms 3.6 ms -34.38%
test_elemwise[f=<built-in function gt>-backend='Finch'-side=1000] 62 ms 1.5 ms ×42

@mtsokol
Copy link
Collaborator Author

mtsokol commented Nov 26, 2024

I think we can merge it - the bug was solved in mamba (failing job is unrelated I think)

@hameerabbasi hameerabbasi merged commit 3393a42 into main Nov 26, 2024
14 of 16 checks passed
@hameerabbasi hameerabbasi deleted the micromamba-v2 branch November 26, 2024 16:35
@hameerabbasi
Copy link
Collaborator

Thanks, @mtsokol!

@mtsokol mtsokol mentioned this pull request Nov 26, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants