-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sparse_finch
notebook and upgrade finch-tensor
#820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the nit below.
We still need to wait for finch-tensor/finch-tensor-python#79 |
CodSpeed Performance ReportMerging #820 will degrade performances by 13.78%Comparing Summary
Benchmarks breakdown
|
3bf6b4c
to
9eb6b30
Compare
9eb6b30
to
19a26af
Compare
sparse_finch
notebooksparse_finch
notebook and upgrade finch-tensor
@hameerabbasi Let's upgrade |
Thanks for the update, @mtsokol! |
@hameerabbasi I promise this is the last one 😅 Can you re-approve? Now it's all green! |
Merged! I think we can cut first beta release! |
This PR upgrades
finch-tensor
to0.2.1
and updatessparse_finch.ipynb
to also include "Finch - Galley" configuration and Counting triangles example.