Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sparse_finch notebook and upgrade finch-tensor #820

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

mtsokol
Copy link
Collaborator

@mtsokol mtsokol commented Nov 28, 2024

This PR upgrades finch-tensor to 0.2.1 and updates sparse_finch.ipynb to also include "Finch - Galley" configuration and Counting triangles example.

@mtsokol mtsokol self-assigned this Nov 28, 2024
hameerabbasi
hameerabbasi previously approved these changes Nov 28, 2024
Copy link
Collaborator

@hameerabbasi hameerabbasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the nit below.

examples/sparse_finch.ipynb Outdated Show resolved Hide resolved
@mtsokol
Copy link
Collaborator Author

mtsokol commented Nov 28, 2024

We still need to wait for finch-tensor/finch-tensor-python#79

Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #820 will degrade performances by 13.78%

Comparing notebook-update (1c4d5c6) with main (128a567)

Summary

❌ 2 regressions
✅ 338 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main notebook-update Change
test_index_fancy[side=100-rank=1-format='coo'] 1.2 ms 1.4 ms -13.78%
test_index_slice[side=100-rank=2-format='gcxs'] 2.2 ms 2.5 ms -11.86%

@mtsokol mtsokol force-pushed the notebook-update branch 2 times, most recently from 3bf6b4c to 9eb6b30 Compare December 6, 2024 12:16
@mtsokol mtsokol changed the title Update sparse_finch notebook Update sparse_finch notebook and upgrade finch-tensor Dec 6, 2024
@mtsokol
Copy link
Collaborator Author

mtsokol commented Dec 6, 2024

@hameerabbasi Let's upgrade finch-tensor here also and skip #823. Here's no need to have it in a separate PR.

@mtsokol mtsokol requested a review from hameerabbasi December 6, 2024 12:20
hameerabbasi
hameerabbasi previously approved these changes Dec 6, 2024
@hameerabbasi
Copy link
Collaborator

Thanks for the update, @mtsokol!

@mtsokol
Copy link
Collaborator Author

mtsokol commented Dec 6, 2024

@hameerabbasi I promise this is the last one 😅 Can you re-approve? Now it's all green!

@mtsokol mtsokol merged commit 71d2199 into main Dec 6, 2024
16 of 17 checks passed
@mtsokol mtsokol deleted the notebook-update branch December 6, 2024 13:52
@mtsokol
Copy link
Collaborator Author

mtsokol commented Dec 6, 2024

Merged! I think we can cut first beta release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants