-
-
Notifications
You must be signed in to change notification settings - Fork 131
Adding notebooks to docs #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hameerabbasi, could you review this whenever free? I've added the "Notebooks" section in nav (and it's visible, but not on the home page with an icon just like other sections). Currently, there are also some failures in the Jupyter notebook itself. |
CodSpeed Performance ReportMerging #894 will degrade performances by 44.45%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like matplotlib needs to be added to the docs dependencies.
|
Also please rebase on |
|
Maybe we can just not run the notebook in docs? These dependency errors are basically because The better approach would be to have the standalone notebook files so they do not depend on the sparse envs. I've pushed the changes with execute disabled, let me know your thoughts. |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
What type of PR is this? (check all applicable)
Related issues
Checklist
Please explain your changes below.