Skip to content

Dataset.argmin is broken #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shoyer opened this issue Aug 4, 2014 · 0 comments · Fixed by #210
Closed

Dataset.argmin is broken #205

shoyer opened this issue Aug 4, 2014 · 0 comments · Fixed by #210
Labels
bug

Comments

@shoyer
Copy link
Member

shoyer commented Aug 4, 2014

It appears to drop any variables for which it finds the minimum:

>>> ds = xray.Dataset({'a': ('x', [0, 1])})
>>> ds
<xray.Dataset>
Dimensions:     (x: 2)
Coordinates:
    x              X 
Noncoordinates:
    a              0 
Attributes:
    Empty
>>> ds.argmin('x')
<xray.Dataset>
Dimensions:     ()
Coordinates:
    None
Noncoordinates:
    None
Attributes:
    Empty
@shoyer shoyer added the bug label Aug 4, 2014
@shoyer shoyer mentioned this issue Aug 9, 2014
Closed
shoyer added a commit to shoyer/xarray that referenced this issue Aug 9, 2014
@shoyer
Fix Dataset.argmin
189d935 
Fixes pydata#205.

Includes a failing test (currently skipped) for pydata#209.
@shoyer shoyer mentioned this issue Aug 9, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Dataset.argmin shoyer/xarray
1 participant
@shoyer