Skip to content

Remove remaining usage of pandas Panel #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorisvandenbossche opened this issue Jun 28, 2019 · 1 comment · Fixed by #3058
Closed

Remove remaining usage of pandas Panel #3057

jorisvandenbossche opened this issue Jun 28, 2019 · 1 comment · Fixed by #3058

Comments

@jorisvandenbossche
Copy link
Member

There is still some usage of pd.Panel (just accessing the name in the pandas namespace for isinstance check), eg:

PANDAS_TYPES = (pd.Series, pd.DataFrame, pd.Panel)

We are currently removing Panel from pandas (pandas-dev/pandas#27101), so that breaks xarray (and statsmodels). For that reason, we are going to keep an empty class so that the above use case doesn't directly break. But it would still be good to remove that usage (or only add it for pandas versions below 0.25.0)

@shoyer
Copy link
Member

shoyer commented Jun 28, 2019

Thanks for the heads up! This will be fixed in #3058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants