⚠️ Nightly upstream-dev CI failed ⚠️

[github-actions]

Workflow Run URL

Python 3.9 Test Summary Info

FAILED xarray/tests/test_dask.py::test_map_blocks_error - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks[obj0] - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks[obj1] - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_dask_args - AttributeError:...
FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj0] - Attribute...
FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj1] - Attribute...
FAILED xarray/tests/test_dask.py::test_map_blocks_change_name - AttributeErro...
FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj0] - AttributeErr...
FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj1] - AttributeErr...
FAILED xarray/tests/test_dask.py::test_map_blocks_to_array - AttributeError: ...
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>0]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>1]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>2]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>3]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>4]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>5]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>6]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>7]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>0]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>1]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>2]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>3]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>4]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>5]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>6]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>7]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_template_convert_object - A...
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template_2 - Att...
FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj0] - Attri...
FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj1] - Attri...
FAILED xarray/tests/test_dask.py::test_map_blocks_hlg_layers - AttributeError...
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_line_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_pcolormesh_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_contour_plot

[keewis]

cc @spencerkclark

[mathause]

See Unidata/cftime#236

[mathause]

Minimal example:

import pandas as pd
import cftime

time_1 = cftime.DatetimeGregorian(2000, 1, 1)
time_2 = cftime.DatetimeProlepticGregorian(2001, 1, 1)

s = pd.Series([time_1, time_2])

s.rank(method="dense", numeric_only=False)

xarray/xarray/core/combine.py

Line 96 in 643e89e

rank = series.rank(

xarray/xarray/tests/test_combine.py

Line 856 in 643e89e

def test_combine_by_coords_raises_for_differing_calendars():

---

Edit: To clarify - the example is supposed to raise a TypeError. For cftime master it raises a ValueError which pandas ignores.

[spencerkclark]

FAILED xarray/tests/test_combine.py::test_combine_by_coords_raises_for_differing_calendars

Thanks for tracking this down @mathause and opening the issue upstream!

FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_line_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_pcolormesh_plot
FAILED xarray/tests/test_plot.py::TestCFDatetimePlot::test_cfdatetime_contour_plot

It looks like Unidata/cftime#235 may have broken some code in nc-time-axis. I'll open an issue in cftime tomorrow.

[mathause]

The other issues have to be fixed in cftime, right?

[spencerkclark]

Yes, they need to be fixed upstream, either in nc-time-axis or cftime.

[andersy005]

As of 3 days ago (April 29th), it appears that there are some outstanding issues with dask that need to be resolved, too

FAILED xarray/tests/test_dask.py::test_map_blocks_error - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks[obj0] - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks[obj1] - AttributeError: 'di...
FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_convert_args_to_list[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_dask_args - AttributeError:...
FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj0] - Attribute...
FAILED xarray/tests/test_dask.py::test_map_blocks_add_attrs[obj1] - Attribute...
FAILED xarray/tests/test_dask.py::test_map_blocks_change_name - AttributeErro...
FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj0] - AttributeErr...
FAILED xarray/tests/test_dask.py::test_map_blocks_kwargs[obj1] - AttributeErr...
FAILED xarray/tests/test_dask.py::test_map_blocks_to_array - AttributeError: ...
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>0]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>1]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>2]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>3]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>4]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>5]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>6]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_transformations[<lambda>7]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>0]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>1]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>2]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>3]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>4]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>5]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>6]
FAILED xarray/tests/test_dask.py::test_map_blocks_ds_transformations[<lambda>7]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_da_ds_with_template[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_template_convert_object - A...
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj0]
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template[obj1]
FAILED xarray/tests/test_dask.py::test_map_blocks_errors_bad_template_2 - Att...
FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj0] - Attri...
FAILED xarray/tests/test_dask.py::test_map_blocks_object_method[obj1] - Attri...

[keewis]

we should try to resolve this before the release

[dcherian]

>           if layer.collection_annotations is None:
E           AttributeError: 'dict' object has no attribute 'collection_annotations'

This looks like it comes from our HighLevelGraph manipulations here

xarray/xarray/core/parallel.py

Lines 529 to 546 in f455e00

	# We're adding multiple new layers to the graph:
	# The first new layer is the result of the computation on
	# the array.
	# Then we add one layer per variable, which extracts the
	# result for that variable, and depends on just the first new
	# layer.
	new_layers[gname_l][key] = (operator.getitem, from_wrapper, name)
	hlg = HighLevelGraph.from_collections(
	gname,
	graph,
	dependencies=[arg for arg in npargs if dask.is_dask_collection(arg)],
	)
	for gname_l, layer in new_layers.items():
	# This adds in the getitems for each variable in the dataset.
	hlg.dependencies[gname_l] = {gname}
	hlg.layers[gname_l] = layer

Maybe @crusaderky or @jrbourbeau can tell us what's going wrong?

[keewis]

I've opened #5344 for the nc-time-axis / cftime issue and xfail'ed it in #5343. Closing to get notifications for other upstream-dev issues (once the CI works again).