Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xarray minimum versions policy is more aggressive than NEP-29 #7777

Closed
crusaderky opened this issue Apr 21, 2023 · 1 comment · Fixed by #7793
Closed

xarray minimum versions policy is more aggressive than NEP-29 #7777

crusaderky opened this issue Apr 21, 2023 · 1 comment · Fixed by #7793
Labels
needs triage Issue that has not been reviewed by xarray team member

Comments

@crusaderky
Copy link
Contributor

What is your issue?

In #4179 / #4907, the xarray policy around minimum supported version of dependencies was changed, with the reasoning that the previous policy (based on NEP-29) was too aggressive.
Ironically, this caused xarray to drop Python 3.8 on Jan 26th (#7461), 3 months before what NEP-29 recommends (Apr 14th).
This is hard to defend - and in fact it sparked discontent (see late comments in #7461).

Regardless of what policy xarray decides to use internally, it should never be more aggressive than NEP-29.
The xarray documentation is also incorrect, as it states "Python: 24 months (NEP-29)" which is not, in fact, in NEP-29.

@crusaderky crusaderky added the needs triage Issue that has not been reviewed by xarray team member label Apr 21, 2023
@crusaderky crusaderky changed the title xarray minimum versions policy should not exceed NEP-29 xarray minimum versions policy is more aggressive than NEP-29 Apr 21, 2023
@keewis
Copy link
Collaborator

keewis commented Apr 21, 2023

see also #7765, where there is a bit more information and discussion.

In short, the policy did work like NEP-29 before, but stopped doing so with python 3.8 because python switched from a irregular ~18 month release cycle to a regular 12 month cycle. We can adjust our policy by extending these 24 months to 30 months, which makes it align with NEP-29's 42 months window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Issue that has not been reviewed by xarray team member
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants