Groupby bins empty groups

[rabernat]

This PR fixes a bug in groupby_bins in which empty bins were dropped from the grouped results. Now groupby_bins restores any empty bins automatically. To recover the old behavior, one could apply dropna after a groupby operation.

Fixes #1019

[max-sixty]

Prob don't want to keep this

[rabernat]

oops! yes forgot to take that out

[shoyer]

Rather than adding a new keyword argument, I'm inclined to unilaterally set drop_empty_bins=True and treat the former behavior as a bug. I can't see many use cases for the previous behavior.

[rabernat]

@shoyer So do you want the keyword argument dropped altogether? Or just the default changed (as in my last commit)?

I can imagine wanting to drop the empty bins in some cases, but not as default. So I would vote to keep the keyword argument.

[shoyer]

Yeah my inclination would be not to add the option at all.
On Sun, Oct 2, 2016 at 7:16 PM Ryan Abernathey notifications@github.com
wrote:

@shoyer https://github.com/shoyer So do you want the keyword argument
dropped altogether? Or just the default changed (as in my last commit)?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1027 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABKS1l-Mw7ojnUQM14ZoCVXwFtA2prn-ks5qwGV7gaJpZM4KMH6y
.

[rabernat]

I guess it's pretty easy to just do dropna

[fmaussion]

Just for future readers like me: the point of this PR is to make drop_empty_bins = False per default, right? (not True as Stephan wrote). Maybe a new edit of @rabernat 's original post would help.

[rabernat]

@fmaussion it's a little more involved than that...see edited description.

[shoyer]

Thanks!