Skip to content

Conversation

VeckoTheGecko
Copy link
Contributor

@VeckoTheGecko VeckoTheGecko commented Jul 11, 2025

So, looks like there was a bug in #10201 that made it so it was labeling every PR as topic-documentation, even this PR.

I think its because the any-glob-to-any-file: is an OR, and technically everything is either in 'doc/**/*' or in '!doc/whats-new.rst'.

Fixed now

  • Closes None

@VeckoTheGecko VeckoTheGecko changed the title Fix labeler topic-documentation Fix labeler for topic-documentation Jul 11, 2025
@github-actions github-actions bot added topic-documentation Automation Github bots, testing workflows, release automation labels Jul 11, 2025
@VeckoTheGecko
Copy link
Contributor Author

(this PR will only take effect post merge since the bot is looking at the config in main)

@VeckoTheGecko

This comment was marked as outdated.

@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Jul 12, 2025

wasn't intrusive

Actually, thinking about this - it isnt ideal having changes to 'what's new' also being tagged as documentation since that also includes code changes.

I'll work on a proper fix

@VeckoTheGecko
Copy link
Contributor Author

VeckoTheGecko commented Jul 14, 2025

Updated and is working as intended. See the following for testing:

VeckoTheGecko#5
VeckoTheGecko#6
VeckoTheGecko#7

Ready for review

@dcherian
Copy link
Contributor

Let's try it, thanks!

@dcherian dcherian merged commit 1f161de into pydata:main Jul 14, 2025
35 of 37 checks passed
@VeckoTheGecko VeckoTheGecko deleted the fix-linkcheck branch July 15, 2025 07:22
dcherian added a commit to jsignell/xarray that referenced this pull request Jul 18, 2025
* main: (94 commits)
  Restructure API documentation into organized sections (pydata#10540)
  Fix convert calendar with different dimension name (pydata#10544)
  Fix kerchunk error in docs build (pydata#10545)
  Call super().__init__() in st.SearchStrategy subclasses (pydata#10543)
  CI: update actions location (pydata#10529)
  meta: Fix labeler topic-documentation (pydata#10524)
  drop_vars: use emit_user_level_warning (pydata#10528)
  Pydap flaky tests (pydata#10525)
  Remove test skip (pydata#10523)
  Improve warning message and tests for timedelta decoding (pydata#10508)
  Add dev whats-new (pydata#10522)
  Add release notes for v2025.07.1 (pydata#10520)
  Updates for Zarr 3 Dtypes (pydata#10456)
  Update Custom Indexes section in api.rst (pydata#10517)
  Expression not assigned (pydata#10507)
  Raise if `Index.create_variables` returns more variables than passed in through `set_xindex` (pydata#10503)
  Allow setting (or skipping) new indexes in open_dataset (pydata#8051)
  doc: add Pandas(Multi)Index to api reference (pydata#10515)
  Update pre-commit hooks (pydata#10510)
  Update pre-commit ruff legacy alias (pydata#10511)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation topic-documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants