-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix reverting default netCDF engine (and prepare 2025.10.1 release) #10828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If anyone has time to review, please do soon. I plan to merge and issue a new release by end of day. it should have been a red-flag that I didn't have to update any tests before! |
For what it's worth, it looks good to me. Thanks for picking this up so promptly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just found some bits of unreverted docstring sprinkled about:
"h5netcdf" over "scipy" over "netcdf4" (customizable via
Is this in the current version of my PR? I read over the changes again and I don't see any glitches like that. |
Yeah I should have specified that it isn't in the files touched by this PR: diff --git a/xarray/backends/api.py b/xarray/backends/api.py
index 3ef75dcd..347dfb22 100644
--- a/xarray/backends/api.py
+++ b/xarray/backends/api.py
@@ -416,7 +416,7 @@ def open_dataset(
or subclass of xarray.backends.BackendEntrypoint, optional
Engine to use when reading files. If not provided, the default engine
is chosen based on available dependencies, by default preferring
- "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``). A custom backend
class (a subclass of ``BackendEntrypoint``) can also be used.
chunks : int, dict, 'auto' or None, default: None
@@ -660,7 +660,7 @@ def open_dataarray(
or subclass of xarray.backends.BackendEntrypoint, optional
Engine to use when reading files. If not provided, the default engine
is chosen based on available dependencies, by default preferring
- "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``). A custom backend
class (a subclass of ``BackendEntrypoint``) can also be used.
chunks : int, dict, 'auto' or None, default: None
@@ -1450,7 +1450,7 @@ def open_mfdataset(
or subclass of xarray.backends.BackendEntrypoint, optional
Engine to use when reading files. If not provided, the default engine
is chosen based on available dependencies, by default preferring
- "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``). A custom backend
class (a subclass of ``BackendEntrypoint``) can also be used.
data_vars : {"minimal", "different", "all"} or list of str, default: "all"
diff --git a/xarray/backends/writers.py b/xarray/backends/writers.py
index a1b02338..bbdecfbc 100644
--- a/xarray/backends/writers.py
+++ b/xarray/backends/writers.py
@@ -547,7 +547,7 @@ def save_mfdataset(
engine : {"netcdf4", "scipy", "h5netcdf"}, optional
Engine to use when writing netCDF files. If not provided, the
default engine is chosen based on available dependencies, by default
- preferring "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ preferring "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``).
compute : bool
If true compute immediately, otherwise return a
diff --git a/xarray/core/dataarray.py b/xarray/core/dataarray.py
index 97b5c684..f4b4de1b 100644
--- a/xarray/core/dataarray.py
+++ b/xarray/core/dataarray.py
@@ -4171,7 +4171,7 @@ class DataArray(
engine : {"netcdf4", "scipy", "h5netcdf"}, optional
Engine to use when writing netCDF files. If not provided, the
default engine is chosen based on available dependencies, by default
- preferring "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ preferring "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``).
encoding : dict, optional
Nested dictionary with variable names as keys and dictionaries of
diff --git a/xarray/core/dataset.py b/xarray/core/dataset.py
index 55bd564c..ce1b0a52 100644
--- a/xarray/core/dataset.py
+++ b/xarray/core/dataset.py
@@ -2058,7 +2058,7 @@ class Dataset(
engine : {"netcdf4", "scipy", "h5netcdf"}, optional
Engine to use when writing netCDF files. If not provided, the
default engine is chosen based on available dependencies, by default
- preferring "h5netcdf" over "scipy" over "netcdf4" (customizable via
+ preferring "netcdf4" over "scipy" over "h5netcdf" (customizable via
``netcdf_engine_order`` in ``xarray.set_options()``).
encoding : dict, optional
Nested dictionary with variable names as keys and dictionaries of |
@jsignell thanks for pointing this out! fixed |
xref #10657