Fix indexing bugs in CoordinateTransformIndex
#10980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
topic-indexing
topic-testing
topic-hypothesis
The return statement was incorrectly indented inside the for loop, causing only the first coordinate to be assigned to the DataArray. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
* main: Document limitations of cftime arithmetic (pydata#10653) Remove RTD htmlzip output format (pydata#10977) Support decoding unsigned integers to timedelta (pydata#10972) Use `._data` in `Variable._replace` (pydata#10969) small changes to the pixi env definitions (pydata#10976) Add GitHub Codespaces config for Pixi (pydata#10929) Fix workflow name to embed `matrix.pytest-addopts` (pydata#10970)
keewis
reviewed
Dec 5, 2025
Collaborator
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
I think there's a logic error in your tests, so it might be good to resolve that before merging
| microseconds_offset = draw(st.integers(0, timespan_microseconds)) | ||
|
|
||
| return min_value + datetime.timedelta(microseconds=microseconds_offset) | ||
|
|
Collaborator
There was a problem hiding this comment.
these are neat, I remember looking for strategies like this before
* main: Switch from `sphinx-llms-txt` => `sphinx-llm` (pydata#11003) Backend fastpath (pydata#10937) Change behavior of `keep_attrs` in `xr.where` when x is a scalar (pydata#10997) make error message more clear (pydata#10994) Address pandas-related upstream errors in pydata#10973 (pydata#10988) new release section (pydata#10985) set the release date (pydata#10984) release v2025.12.0 (pydata#10981) Add sphinx-llms-txt (pydata#10978)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some severe bugs noticed downstream in rasterix
Disclaimer: had lots of help from Claude in writing the strategies but I have reviewed them closely