Skip to content

PERF: Override equals in IndexVariable #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2017
Merged

PERF: Override equals in IndexVariable #1256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
476400b
override equals in IndexVariable
max-sixty Feb 8, 2017
ff2545f
is not none
max-sixty Feb 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions xarray/core/variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,6 +1247,19 @@ def copy(self, deep=True):
return type(self)(self.dims, self._data, self._attrs,
self._encoding, fastpath=True)

def equals(self, other, equiv=None):
# if equiv is specified, super up
if equiv is not None:
return super(IndexVariable, self).equals(other, equiv)

# otherwise use the native index equals, rather than looking at _data
other = getattr(other, 'variable', other)
try:
return (self.dims == other.dims and
self._data_equals(other))
except (TypeError, AttributeError):
return False

def _data_equals(self, other):
return self.to_index().equals(other.to_index())

Expand Down