Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ISSUE_TEMPLATE for github and xr.show_versions() #1485

Merged
merged 15 commits into from
Oct 28, 2017
Merged

add ISSUE_TEMPLATE for github and xr.show_versions() #1485

merged 15 commits into from
Oct 28, 2017

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jul 21, 2017

This PR adds a new module level function xr.show_versions() and a new Github Issue Template to help with debugging user issues. Hopefully, we stop having to ask "what version of dask are you using?" Functionality is copied from pandas.

@fmaussion
Copy link
Member

This is a good idea!

But it is going to be a mess until a new version of xarray is released, since users won't have access to the utility function...

@jhamman
Copy link
Member Author

jhamman commented Jul 21, 2017

But it is going to be a mess until a new version of xarray is released, since users won't have access to the utility function...

Good point. I guess we could hold off on merging for a bit then.

Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's either hold off on merging this until shortly before the next xarray release, or merge everything except the issue template.

("xarray", lambda mod: mod.__version__),
("pandas", lambda mod: mod.__version__),
("numpy", lambda mod: mod.version.version),
("scipy", lambda mod: mod.version.version),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use mod.__version__ for numpy and scipy? That's the more standard way to access this information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that works. Done.

@jhamman
Copy link
Member Author

jhamman commented Jul 24, 2017

Let's just wait until we have our next release.

@jhamman jhamman modified the milestone: 0.10 Aug 4, 2017
@jhamman jhamman mentioned this pull request Aug 28, 2017
13 tasks
@jhamman jhamman merged commit 3a99529 into pydata:master Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants