Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roundtrip unicode strings even when written as character arrays #1648

Merged
merged 10 commits into from
Oct 27, 2017
Merged

Roundtrip unicode strings even when written as character arrays #1648

merged 10 commits into from
Oct 27, 2017

Commits on Oct 22, 2017

  1. Decoding support for conventions.CharToStringArray

    @shoyer
    shoyer committed Oct 22, 2017
    Configuration menu
    Copy the full SHA
    f11931d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Round unicode strings to disk even with NC_CHAR by using utf-8 encoding

    @shoyer
    shoyer committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    8632cd7 View commit details
    Browse the repository at this point in the history

  2. Docs on string encoding

    @shoyer
    shoyer committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    f2a4fa4 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Fixup per review (and avoid supporting _FillValue yet for unicode str… 

    …ings)
    @shoyer
    shoyer committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    f8142a3 View commit details
    Browse the repository at this point in the history

  2. clarify warning

    @shoyer
    shoyer committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    2e8f554 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2017

  1. Merge branch 'master' into ncchar-string-encoding

    @shoyer
    shoyer committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    cdaace3 View commit details
    Browse the repository at this point in the history

  2. Use assert_identical instead of assert_allclose for roundtrip_append … 

    …tests
    @shoyer
    shoyer committed Oct 25, 2017
    Configuration menu
    Copy the full SHA
    f918251 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Fix tests; add variable name to more errors

    @shoyer
    shoyer committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    b29aad6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into ncchar-string-encoding

    @shoyer
    shoyer committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    d6694e2 View commit details
    Browse the repository at this point in the history

  3. add back in dropped @required_scipy decorator

    @shoyer
    shoyer committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    72ff454 View commit details
    Browse the repository at this point in the history