Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong error message in interp() #2598

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Fix wrong error message in interp() #2598

merged 1 commit into from
Dec 11, 2018

Conversation

lumbric
Copy link
Contributor

@lumbric lumbric commented Dec 11, 2018

This is just a minor fix of a wrong error message. Please let me know if you think that this is worth testing in unit tests.

Before:

>>> import xarray as xr
>>> d = xr.DataArray([1,2,3])
>>> d.interp(1)
...
ValueError: the first argument to .rename must be a dictionary

After:

>>> import xarray as xr
>>> d = xr.DataArray([1,2,3])
>>> d.interp(1)
...

ValueError: the first argument to .interp must be a dictionary

@pep8speaks
Copy link

Hello @lumbric! Thanks for submitting the PR.

@shoyer
Copy link
Member

shoyer commented Dec 11, 2018

Good catch -- thanks!

@shoyer shoyer merged commit 6881503 into pydata:master Dec 11, 2018
dcherian pushed a commit to yohai/xarray that referenced this pull request Dec 16, 2018
Merge remote-tracking branch 'upstream/master' into yohai-ds_scatter
6975b9e 
* upstream/master:
  Feature: N-dimensional auto_combine (pydata#2553)
  Support HighLevelGraphs (pydata#2603)
  Bump cftime version in doc environment (pydata#2604)
  use keep_attrs in binary operations II (pydata#2590)
  Temporarily mark dask-dev build as an allowed failure (pydata#2602)
  Fix wrong error message in interp() (pydata#2598)
  Add dayofyear and dayofweek accessors (pydata#2599)
  Fix h5netcdf saving scalars with filters or chunks (pydata#2591)
  Minor update to PR template (pydata#2596)
  Zarr consolidated (pydata#2559)
  fix examples (pydata#2581)
  Fix typo (pydata#2578)
  Concat docstring typo (pydata#2577)
  DOC: remove example using Dataset.T (pydata#2572)
  python setup.py test now works by default (pydata#2573)
  Return slices when possible from CFTimeIndex.get_loc() (pydata#2569)
  DOC: fix computation.rst (pydata#2567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumbric @pep8speaks @shoyer