Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate compat & encoding #2703

Merged
merged 11 commits into from
Feb 1, 2019
Merged

deprecate compat & encoding #2703

merged 11 commits into from
Feb 1, 2019

Conversation

max-sixty
Copy link
Collaborator

@max-sixty max-sixty commented Jan 24, 2019 •
edited
Loading

Still need to adjust the tests

shoyer
shoyer reviewed Jan 24, 2019
View reviewed changes
xarray/core/dataarray.py Outdated Show resolved Hide resolved
xarray/core/dataarray.py Outdated Show resolved Hide resolved
xarray/core/dataset.py Outdated Show resolved Hide resolved
@max-sixty
Copy link
Collaborator Author

Green!

@max-sixty
Copy link
Collaborator Author

Green!

Please could someone review and approve?

@max-sixty max-sixty merged commit d634f64 into pydata:master Feb 1, 2019
@max-sixty max-sixty deleted the deprecate-compat branch February 1, 2019 03:16
dcherian pushed a commit to yohai/xarray that referenced this pull request Feb 4, 2019
Merge branch 'master' into yohai-ds_scatter
4e41fc3 
* master:
  remove xfail from test_cross_engine_read_write_netcdf4 (pydata#2741)
  Reenable cross engine read write netCDF test (pydata#2739)
  remove bottleneck dev build from travis, this test env was failing to build (pydata#2736)
  CFTimeIndex Resampling (pydata#2593)
  add tests for handling of empty pandas objects in constructors (pydata#2735)
  dropna() for a Series indexed by a CFTimeIndex (pydata#2734)
  deprecate compat & encoding (pydata#2703)
  Implement integrate (pydata#2653)
  ENH: resample methods with tolerance (pydata#2716)
  improve error message for invalid encoding (pydata#2730)
  silence a couple of warnings (pydata#2727)
@shoyer shoyer mentioned this pull request Sep 4, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer left review comments

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-sixty @shoyer @jhamman