Switch the name of datetime components from 'time.month' to 'month' #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH345
This lets you write things like:
counts = time.groupby('time.month').count()
counts.sel(month=2)
instead of the previously valid
counts.sel(**{'time.month': 2})
which is much more awkward
CC jhamman
shoyer
force-pushed
the
datetime-shortcut
branch
from
a480df9 to
918016b
Compare
shoyer
added a commit
that referenced
this pull request
Mar 2, 2015
Switch the name of datetime components from 'time.month' to 'month'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #345
This lets you write things like:
instead of the previously valid
which is much more awkward. Note that this breaks existing code which relied on the old usage.
CC @jhamman