Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave empty slot when not using accessors #3531

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Nov 14, 2019

Save a few bytes and nanoseconds for the overwhelming majority of the users that don't use accessors.
Lay the groundwork for potential future use of @pandas.utils.cache_readonly.

xref #3514

…til.cache_readonly uses. Do not create cache dict until actually needed.
@crusaderky crusaderky mentioned this pull request Nov 15, 2019
12 tasks
@crusaderky
Copy link
Contributor Author

Ready for review and merge

Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks!

@crusaderky crusaderky merged commit aa876cf into pydata:master Nov 15, 2019
@crusaderky crusaderky deleted the cache_readonly branch November 15, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants