RasterioDeprecationWarning #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `vrt` is opened, a deprecation warning will be shown: ```python /home/taher/.local/apps/miniconda/envs/hydrodata/lib/python3.8/site-packages/xarray/backends/rasterio_.py:241: RasterioDeprecationWarning: dst_nodata will be removed in 1.1, use nodata riods = WarpedVRT(riods, **vrt_params) /home/taher/.local/apps/miniconda/envs/hydrodata/lib/python3.8/site-packages/xarray/backends/rasterio_.py:35: RasterioDeprecationWarning: dst_nodata will be removed in 1.1, use nodata riods = WarpedVRT(riods, **vrt_params) /home/taher/.local/apps/miniconda/envs/hydrodata/lib/python3.8/site-packages/xarray/backends/rasterio_.py:122: RasterioDeprecationWarning: dst_nodata will be removed in 1.1, use nodata riods = WarpedVRT(riods, **self.vrt_params) ``` This change can be confirmed in `rasterio`'s documentation where `dst_nodata` is replaced with nodata. https://rasterio.readthedocs.io/en/latest/api/rasterio.vrt.html
|
Thanks @cheginit ! I know it's a small change, but would you be up for adding a whatsnew entry and giving yourself credit? |
|
Sure! |
|
Cheers @cheginit ! |
|
Thanks! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
May 1, 2020
* upstream/master: (39 commits) Pint support for DataArray (pydata#3643) Apply blackdoc to the documentation (pydata#4012) ensure Variable._repr_html_ works (pydata#3973) Fix handling of abbreviated units like msec (pydata#3998) full_like: error on non-scalar fill_value (pydata#3979) Fix some code quality and bug-risk issues (pydata#3999) DOC: add pandas.DataFrame.to_xarray (pydata#3994) Better chunking error messages for zarr backend (pydata#3983) Silence sphinx warnings (pydata#3990) Fix distributed tests on upstream-dev (pydata#3989) Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956) keep attrs in interpolate_na (pydata#3970) actually use preformatted text in the details summary (pydata#3978) facetgrid: Ensure that colormap params are only determined once. (pydata#3915) RasterioDeprecationWarning (pydata#3964) Empty line missing for DataArray.assign_coords doc (pydata#3963) New coords to existing dim (doc) (pydata#3958) implement a more threadsafe call to colorbar (pydata#3944) Fix wrong order of coordinate converted from pd.series with MultiIndex (pydata#3953) Updated list of core developers (pydata#3943) ...
|
Would you like to add this update to rioxarray as well? If not, mind if I port it over? |
|
@snowman2 Sure would be happy to. |
|
@snowman2 I went through the code and didn't find any |
|
@cheginit, thanks for being willing. The part to modify is here: https://github.com/corteva/rioxarray/blob/6587726a019f46ec68ca94d6cea866abea956a2a/rioxarray/_io.py#L657 |
cheginit
added a commit
to cheginit/rioxarray
that referenced
this pull request
Jun 10, 2020
Following the discussion on [xarray](pydata/xarray#3964), this PR addresses the RasterioDeprecationWarning.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
vrtis opened, a deprecation warning will be shown:This change can be confirmed in
rasterio's documentation wheredst_nodatais replaced with nodata.https://rasterio.readthedocs.io/en/latest/api/rasterio.vrt.html