Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding existing variables in to_zarr() without appending #4029

Merged
merged 2 commits into from
May 5, 2020

Conversation

shoyer
Copy link
Member

@shoyer shoyer commented May 5, 2020

This is nice for consistency with to_netcdf. It should be useful for cases where users want to update values in existing Zarr datasets.

  • Tests added
  • Passes isort -rc . && black . && mypy . && flake8
  • Fully documented, including whats-new.rst for all changes and api.rst for new API

This should be useful for cases where users want to update values in existing
Zarr datasets.
@rabernat
Copy link
Contributor

rabernat commented May 5, 2020

This is great Stephan. Perhaps you could also update the to_zarr docstring to make it more consistent with to_netcdf and explicitly describe this behavior. For to_netcdf, we say

If mode=’a’, existing variables will be overwritten.

@shoyer
Copy link
Member Author

shoyer commented May 5, 2020

Thanks for the reviews!

The doc build failure is something else (see #4030), so I'm going to submit.

@shoyer shoyer merged commit 1c5adc9 into pydata:master May 5, 2020
dcherian added a commit to kmuehlbauer/xarray that referenced this pull request May 9, 2020
…k-issues

* upstream/master: (22 commits)
  support darkmode (pydata#4036)
  Use literal syntax instead of function calls to create the data structure (pydata#4038)
  Add template xarray object kwarg to map_blocks (pydata#3816)
  Transpose coords by default (pydata#3824)
  Remove broken test for Panel with to_pandas() (pydata#4028)
  Allow warning with cartopy in docs plotting build (pydata#4032)
  Support overriding existing variables in to_zarr() without appending (pydata#4029)
  chore: Remove unnecessary comprehension (pydata#4026)
  fix to_netcdf docstring typo (pydata#4021)
  Pint support for DataArray (pydata#3643)
  Apply blackdoc to the documentation (pydata#4012)
  ensure Variable._repr_html_ works (pydata#3973)
  Fix handling of abbreviated units like msec (pydata#3998)
  full_like: error on non-scalar fill_value (pydata#3979)
  Fix some code quality and bug-risk issues (pydata#3999)
  DOC: add pandas.DataFrame.to_xarray (pydata#3994)
  Better chunking error messages for zarr backend (pydata#3983)
  Silence sphinx warnings (pydata#3990)
  Fix distributed tests on upstream-dev (pydata#3989)
  Add multi-dimensional extrapolation example and mention different behavior of kwargs in interp (pydata#3956)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants