Autodetect the engine only when engine=None
#4458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexamici
changed the title
engine=Noneengine=None
dcherian
reviewed
Sep 25, 2020
jhamman
reviewed
Sep 25, 2020
Member
jhamman
left a comment
jhamman
left a comment
There was a problem hiding this comment.
Looks great. Just a few small comments.
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Collaborator
Author
Member
|
I'm going to merge this now. The doc build failure is unrelated to the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use the
engineexplicitly selected by the user and perform auto detection only whenengine=None.enginekey in some cases when opening file objects #4457isort . && black . && mypy . && flake8whats-new.rstThe refactor complexity stems mostly from moving or duplicating some logic from
_get_engine_from_magic_numberto the backend stores. The current, rather ugly, code minimizes changes to the error conditions and messages.Later in the backend refactor the plugins will provide the functionalities to identify the format from the file content and the duplication should be eliminated.
@jhamman do you think I need to acknowledge the CZI sponsorship in the changelog?