Move get_chunks from zarr.py to dataset.py #4632
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is to split the PR #4595 in small PRs.
In this smaller PR there aren't changes in xarry interfaces, it's only a small code refactor:
Move
get_chunks
from zarr.py to dataset.pyAlign
apiv2
toapiv1
: inapiv2
replacezarr.ZarrStore.maybe_chunk
withdataset._maybe_chunk
andzarr.ZarrStore.get_chunk
withdataset._get_chunks
.remove
zarr.ZarrStore.maybe_chunk
andzarr.ZarrStore.get_chunks
(no more used)Related Flexible backends - Harmonise zarr chunking with other backends chunking #4496
Passes
isort . && black . && mypy . && flake8
No user visible changes (including notable bug fixes) are documented in
whats-new.rst
No new functions/methods are listed in
api.rst