Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_chunks from zarr.py to dataset.py #4632

Merged
merged 7 commits into from
Dec 2, 2020
Merged

Move get_chunks from zarr.py to dataset.py #4632

merged 7 commits into from
Dec 2, 2020

Conversation

aurghs
Copy link
Collaborator

@aurghs aurghs commented Dec 1, 2020

The aim is to split the PR #4595 in small PRs.
In this smaller PR there aren't changes in xarry interfaces, it's only a small code refactor:

  • Move get_chunks from zarr.py to dataset.py

  • Align apiv2 to apiv1: in apiv2 replace zarr.ZarrStore.maybe_chunk with dataset._maybe_chunk and zarr.ZarrStore.get_chunk with dataset._get_chunks.

  • remove zarr.ZarrStore.maybe_chunk and zarr.ZarrStore.get_chunks (no more used)

  • Related Flexible backends - Harmonise zarr chunking with other backends chunking #4496

  • Passes isort . && black . && mypy . && flake8

  • No user visible changes (including notable bug fixes) are documented in whats-new.rst

  • No new functions/methods are listed in api.rst

@alexamici alexamici self-requested a review December 1, 2020 10:30
@aurghs aurghs changed the title Move get chunks in dataset Move get_chunks from zarr.py to dataset.py Dec 1, 2020
Copy link
Collaborator

@alexamici alexamici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple refactor that moves common code out of zarr. No other change.

@shoyer & @jhamman I'll merge it soon as other changes we have depend in this.

xarray/core/dataset.py Outdated Show resolved Hide resolved
@alexamici alexamici merged commit 6530895 into pydata:master Dec 2, 2020
@aurghs aurghs deleted the move_get_chunks_in_dataset branch February 11, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants