Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a read-only TileDB backend #4988

Closed
wants to merge 1 commit into from
Closed

feat: Add a read-only TileDB backend #4988

wants to merge 1 commit into from

Conversation

jp-dark
Copy link
Contributor

@jp-dark jp-dark commented Mar 2, 2021 •
edited
Loading

  • Add TileDB backend using plugin architecture
  • Add backend tests (82% coverage for xarray/backends/tiledb_.py)
  • Add dask/distributed integration tests for both integer and datetime
    TileDB dimensions.
  • Closes A read-only TileDB backend #4987
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

@pep8speaks
Copy link

pep8speaks commented Mar 2, 2021 •
edited
Loading

Hello @jp-dark! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-03 14:46:52 UTC

@jp-dark @gsakkis
feat: Add a read-only TileDB backend
feb02af 
* Add TileDB backend using plugin architecture
* Add backend tests (82% coverage for `xarray/backends/tiledb_.py`)
* Add dask/distributed integration tests for both integer and datetime
TileDB dimensions.

Issues: GH4987

Co-authored-by: gsakkis <george.sakkis@tiledb.com>
@jp-dark jp-dark force-pushed the jpd/tiledb-backend branch from 1e5adee to feb02af Compare March 3, 2021 14:46
@jhamman jhamman mentioned this pull request Mar 3, 2021
Closed
keewis
keewis reviewed Mar 4, 2021
View reviewed changes
xarray/backends/tiledb_.py
return result.reshape(shape)


class TileDBDataStore(AbstractDataStore):
Copy link
Collaborator

@keewis keewis Mar 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is a misconception on my part, but I thought DataStore and AbstractDataStore are part of the old API and replaced by BackendEntrypoint. Any comments on that, @alexamici, @aurghs?

@jp-dark
Copy link
Contributor Author

jp-dark commented Mar 9, 2021

This work is being moved outside of xarray using new entry point procedure.

@jp-dark jp-dark closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A read-only TileDB backend
3 participants
@jp-dark @pep8speaks @keewis