Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ffill and bfill along chunked dimensions #5187

Merged
merged 7 commits into from
Apr 26, 2021
Merged

Support ffill and bfill along chunked dimensions #5187

merged 7 commits into from
Apr 26, 2021

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Apr 18, 2021 •
edited
Loading

@max-sixty
Copy link
Collaborator

Looks good — though I don't know the dask interface that well. The tests look good though.

@pep8speaks
Copy link

pep8speaks commented Apr 20, 2021 •
edited
Loading

Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-24 02:32:02 UTC

@dcherian dcherian requested a review from mathause April 20, 2021 22:24
dcherian
dcherian commented Apr 20, 2021
View reviewed changes
doc/whats-new.rst Outdated Show resolved Hide resolved
mathause
mathause approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

xarray/core/duck_array_ops.py Outdated Show resolved Hide resolved
@dcherian @mathause
Update xarray/core/duck_array_ops.py
9596302 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@dcherian
Copy link
Contributor Author

Thanks for the reviews. I'll merge in a couple of days if there are no comments.

keewis
keewis reviewed Apr 23, 2021
View reviewed changes
Copy link
Collaborator

@keewis keewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, although I would probably move the dask implementation to dask_array_ops.

@dcherian
Copy link
Contributor Author

looks good to me, although I would probably move the dask implementation to dask_array_ops.

Good idea. Done!

@dcherian
Copy link
Contributor Author

dcherian commented Apr 24, 2021 •
edited
Loading

failures are unrelated

commented here: dask/community#150

FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF3_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[netcdf4-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_netcdf_roundtrip[h5netcdf-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF3_CLASSIC]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[netcdf4-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[h5netcdf-NETCDF4]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_read_netcdf_integration_test[scipy-NETCDF3_64BIT]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-True]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[True-False]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-True]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_zarr_integration_test[False-False]
FAILED xarray/tests/test_distributed.py::test_dask_distributed_rasterio_integration_test
FAILED xarray/tests/test_distributed.py::test_dask_distributed_cfgrib_integration_test
FAILED xarray/tests/test_distributed.py::test_async - ImportError: cannot imp...
FAILED xarray/tests/test_distributed.py::test_serializable_locks - ImportErro...

@jrbourbeau
Copy link
Contributor

@dcherian could you try restarting CI to pull in the latest dask release? xref dask/community#150 (comment)

@dcherian
Copy link
Contributor Author

@jrbourbeau thanks! It looks like it is working. Very unfortunate timing!

@jrbourbeau
Copy link
Contributor

Yeah, sorry about that. At least it was an easy fix : )

@dcherian dcherian merged commit 69950a4 into pydata:master Apr 26, 2021
@dcherian dcherian deleted the duck-array-push branch April 26, 2021 13:06
@mathause mathause mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keewis keewis keewis left review comments

@mathause mathause mathause approved these changes

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bfill behavior dask arrays with small chunk size
6 participants
@dcherian @max-sixty @pep8speaks @jrbourbeau @mathause @keewis