faceted plots #527

clarkfitzg · 2015-08-12T22:12:12Z

Opening this to provide visibility as I work on this PR.

Currently this has x and y string arguments for 2d plot working, but everything else still needs lots of work. I'll let people know when it's ready for review.

clarkfitzg · 2015-08-13T17:17:05Z

@shoyer Here's what we currently have:

In [15]: g = xray.plot.FacetGrid(t, col='time', col_wrap=2)

In [16]: g.map_dataarray(xray.plot.contourf, 'lon', 'lat')
Out[16]: <xray.plot.facetgrid.FacetGrid at 0x10de082d0>

Right now this assumes that the function for map_dataarray has the same signature as 2d xray plotting methods.

clarkfitzg · 2015-08-14T00:47:54Z

Here's what a 4d array looks like.

In [26]: t4d = xray.concat([t2, t2 + 50], pd.Index(['normal', 'hot'], name='fourth_dim'))

# This is a 4d array
In [27]: t4d.coords
Out[27]: 
Coordinates:
  * lat         (lat) float32 75.0 72.5 70.0 67.5 65.0 62.5 60.0 57.5 55.0 ...
  * lon         (lon) float32 200.0 202.5 205.0 207.5 210.0 212.5 215.0 ...
  * time        (time) datetime64[ns] 2013-01-01 2013-03-04T12:00:00
  * fourth_dim  (fourth_dim) object 'normal' 'hot'

In [28]: g = xray.plot.FacetGrid(t4d, col='time', row='fourth_dim')

In [29]: g.map_dataarray(xray.plot.imshow, 'lon', 'lat')
Out[29]: <xray.plot.facetgrid.FacetGrid at 0x10f5aad90>

jhamman · 2015-08-14T05:10:45Z

@clarkfitzg - These are looking really great. I think this is going to be a really useful tool.

The colorbar label is too close to the colorbar tick label, are we manually placing that or is this a matplotlib thing?

clarkfitzg · 2015-08-14T16:37:28Z

Thanks! The colorbar label spacing is a matplotlib thing- it only became a problem after rotating it to match the row labels. So I expect that I can fix it by changing the anchor point or placing it manually.

shoyer · 2015-08-14T20:01:03Z

xray/plot/facetgrid.py

+                #plt.title('{coord} = {val}'.format(coord=self.col,
+                #    val=str(name)[:10]))
+        else:
+            # Looping over the indices helps keep sanity


Maybe you can write something like the facet_data method from Seaborn's FacetGrid? That seems like a nice separation of the iteration logic from the plotting logic

That's on my todo list- I better post that list here.

clarkfitzg · 2015-08-14T21:13:12Z

shoyer · 2015-09-03T23:44:26Z

xray/plot/facetgrid.py

+    '''
+
+    def __init__(self, darray, col=None, row=None, col_wrap=None,
+            aspect=1, size=3, margin_titles=True):


This is a minor point, but take a look at the PEP8 indentation guidelines:
https://www.python.org/dev/peps/pep-0008/#indentation

This is an example of the first "No" case :)

Just ran this through pep8 command line utility- lots of violations. Fixed.

shoyer · 2015-09-04T18:22:48Z

For the simple example in the doc -- use imshow instead of contourf? The result is definitely more aesthetically pleasing:

shoyer · 2015-09-04T18:32:45Z

xray/plot/facetgrid.py

+
+        self.set_titles()
+
+    def __iter__(self):


My inclination is to not add this convenience shortcut, for two reasons:

It's a departure from Seaborn, so it's something new for users to learn.

It's not really necessary -- iterating over grid.axes.flat is much more explicit (generally a good thing), and only slightly more verbose.

I added this with the idea of using an abc with this class: https://docs.python.org/2/library/collections.html#collections-abstract-base-classes.

Reviewing the available abc's, I don't think we stand to gain any benefit from them. At the same time, it is conceptually a 2d array. I suppose that structure is captured well enough in the axes and name_dicts.

shoyer · 2015-09-04T18:44:51Z

xray/plot/facetgrid.py

+        """
+        Parameters
+        ----------
+        darray : DataArray


Let's call this parameter data, like Seaborn. Eventually we might support dataset objects, too.

clarkfitzg · 2015-09-04T19:37:08Z

@shoyer Latest commit also added a little more to the docs on how to use the attributes data axes, and name_dicts.

shoyer · 2015-09-04T19:55:17Z

xray/plot/facetgrid.py

+        self.col = col
+        self.col_wrap = col_wrap
+
+        # Next the private variables


These variables are all duplicated between private versions (below) and public versions (above). For now, let's stick with the conservative choice of keeping them private like seaborn?

clarkfitzg · 2015-09-04T21:05:18Z

doc/plotting.rst

@@ -45,16 +48,18 @@ Imports
    # Use defaults so we don't get gridlines in generated docs
    import matplotlib as mpl
    mpl.rcdefaults()
+    mpl.rcParams.update({'figure.autolayout': True})


what is this doing? I think nothing.

Maybe this is undoing the seaborn import? If it doesn't seem to be changing the doc build, take it out.

shoyer · 2015-09-04T22:18:11Z

doc/api.rst

@@ -411,3 +411,15 @@ Plotting
   plot.imshow
   plot.line
   plot.pcolormesh
+   plot.FacetGrid
+
+FacetGrid methods


one more suggestion: clarkfitzg#2

we can remove this methods and let them just show up on the doc page for FacetGrid.

shoyer · 2015-09-04T22:19:10Z

I think this is pretty much good to go. Merge at your discretion!

don't show FacetGrid methods directly in API docs

clarkfitzg · 2015-09-04T22:25:25Z

Ok, going to merge once the build passes. Will continue with the rest of the stuff next week. @shoyer should I rebase or squash these commits?

shoyer · 2015-09-04T22:35:11Z

I haven't been very careful about insisting on a clean git history so far, so don't worry about rebase/squash.

faceted plots

clarkfitzg added 3 commits August 12, 2015 14:42

add parameter add_labels=True to turn off labeling

3030f86

Merge branch 'master' into facet2

d5ef818

facets share common colorbar

30385f8

clarkfitzg added 4 commits August 13, 2015 10:19

display colorbar on facetgrid

9e9d8ee

beginning logic for row/col facets

9f12a32

about to bring in set_label from seaborn

8516c5c

labeled grid using seaborn

2f1fa0c

rotate text to match

ef5e2e2

shoyer reviewed Aug 14, 2015
View reviewed changes

properly place colorbar label

e8e2f1e

add failing test for figure labels

900ec93

clarkfitzg mentioned this pull request Aug 17, 2015

Support group_over #324

Open

clarkfitzg added 13 commits August 24, 2015 09:30

Merge branch 'master' into facet2

058fda9

Merge branch 'master' into facet2

a82e019

data structures for facetgrid

e99d1d5

failing test for floating index

68c7b06

failing test for nonunique index

a5d37df

handle nonunique coordinates

e7bce95

refactor set_titles, add failing test for long titles

11e9f2b

use core.formatting for titles

6686988

failing test for robust kwarg

7d9cdbb

refactoring _determine_cmap_parms

fbfbad1

predictable colormaps for facetgrids

9cdfab7

better tests for colorbars

a0ce7cf

col wrapping works now

870025a

shoyer reviewed Sep 3, 2015
View reviewed changes

clarkfitzg added 2 commits September 4, 2015 10:25

address Stephans comments and pep8 cleanup

266b0bf

Use default axis labels and sizes

29db010

shoyer reviewed Sep 4, 2015
View reviewed changes

change from contourf to imshow for faceted plotting examples

56761af

shoyer reviewed Sep 4, 2015
View reviewed changes

darray now called data, remove iterable behavior on FacetGrid

f6dc6a2

shoyer reviewed Sep 4, 2015
View reviewed changes

attributes all set in bottom of __init__

15babf1

clarkfitzg reviewed Sep 4, 2015
View reviewed changes

shoyer and others added 2 commits September 4, 2015 15:17

don't show FacetGrid methods directly in API docs

99dbb5e

rename plotfunc arg to func

b48a50b

shoyer reviewed Sep 4, 2015
View reviewed changes

Merge pull request #2 from shoyer/facet2

3247fdb

don't show FacetGrid methods directly in API docs

clarkfitzg added a commit that referenced this pull request Sep 4, 2015

Merge pull request #527 from clarkfitzg/facet2

f26b29a

faceted plots

clarkfitzg merged commit f26b29a into pydata:master Sep 4, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

faceted plots #527

faceted plots #527

clarkfitzg commented Aug 12, 2015

clarkfitzg commented Aug 13, 2015

clarkfitzg commented Aug 14, 2015

jhamman commented Aug 14, 2015

clarkfitzg commented Aug 14, 2015

shoyer Aug 14, 2015

clarkfitzg Aug 14, 2015

clarkfitzg commented Aug 14, 2015

shoyer Sep 3, 2015

clarkfitzg Sep 4, 2015

shoyer commented Sep 4, 2015

shoyer Sep 4, 2015

clarkfitzg Sep 4, 2015

shoyer Sep 4, 2015

clarkfitzg commented Sep 4, 2015

shoyer Sep 4, 2015

clarkfitzg Sep 4, 2015

clarkfitzg Sep 4, 2015

shoyer Sep 4, 2015

shoyer Sep 4, 2015

shoyer commented Sep 4, 2015

clarkfitzg commented Sep 4, 2015

shoyer commented Sep 4, 2015

faceted plots #527

faceted plots #527

Conversation

clarkfitzg commented Aug 12, 2015

clarkfitzg commented Aug 13, 2015

clarkfitzg commented Aug 14, 2015

jhamman commented Aug 14, 2015

clarkfitzg commented Aug 14, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clarkfitzg commented Aug 14, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shoyer commented Sep 4, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

clarkfitzg commented Sep 4, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shoyer commented Sep 4, 2015

clarkfitzg commented Sep 4, 2015

shoyer commented Sep 4, 2015