Fix Dataset.where with drop=True and mixed dims #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think a benchmark is required for this new method? |
|
Is this a breaking changes if users might expect the old behavior? |
|
This looks great! Thanks @headtr1ck . I don't think this is doing any additional passes of the data — it's just computing metadata like dims — so I don't think it strictly needs a benchmark. (Though never opposed to more benchmarks...). |
dcherian
added a commit
to bzah/xarray
that referenced
this pull request
Jun 24, 2022
* main: (129 commits) docs on specifying chunks in to_zarr encoding arg (pydata#6542) [skip-ci] List count under Aggregation (pydata#6711) Add `Dataset.dtypes` property (pydata#6706) try to import `UndefinedVariableError` from the new location (pydata#6701) DOC: note of how `chunks` can be defined (pydata#6696) pdyap version dependent client.open_url call (pydata#6656) use `pytest-reportlog` to generate upstream-dev CI failure reports (pydata#6699) [pre-commit.ci] pre-commit autoupdate (pydata#6694) Bump actions/setup-python from 3 to 4 (pydata#6692) Fix Dataset.where with drop=True and mixed dims (pydata#6690) pass kwargs through from save_mfdataset to to_netcdf (pydata#6686) Docs: indexing.rst finetuning (pydata#6685) use micromamba instead of mamba (pydata#6674) install the development version of `matplotlib` into the upstream-dev CI (pydata#6675) Add whatsnew section for v2022.06.0 release notes for 2022.06.0rc0 release notes for the pre-release (pydata#6676) more testpypi workflow fixes (pydata#6673) thin: add examples (pydata#6663) Update multidimensional-coords.ipynb (pydata#6672) ...
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst