Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily import loop_in_thread fixture from distributed #6884

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

jrbourbeau
Copy link
Contributor

This is a quickfix similar to dask/dask#9337. Note there's a conversation happening over in dask/distributed#6806 around what testing utilities in distributed should be considered public.

gen_cluster,
loop,
cleanup,
loop_in_thread,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only available in newer versions of distributed -- what's the minimum version of distributed xarray supports?

Copy link
Member

@andersy005 andersy005 Aug 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andersy005! Actually looking at it more closely, it looks like loop_in_thread has been around for a long time but the need to actually import it is new. So the changes here should both fix the failures we're seeing and also be backwards compatible. It also looks like there's a CI build which tests against the minimum supported version of packages (including distributed)

- env: "min-all-deps"
python-version: "3.8"
os: ubuntu-latest

which is also passing

@jrbourbeau
Copy link
Contributor Author

It's not immediately clear to me why the docs build is failing. Has that been happening elsewhere?

@andersy005
Copy link
Member

andersy005 commented Aug 5, 2022

It's not immediately clear to me why the docs build is failing. Has that been happening elsewhere?

When building docs on RTD, we turn Sphinx warnings into errors. Sphinx is throwing a warning that is then turned into an error after docs are built, as it appears that the SSL certificate for numba.pydata.org has expired or is misconfigured.

loading intersphinx inventory from https://rasterio.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from https://sparse.pydata.org/en/latest/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://numba.pydata.org/numba-doc/latest/objects.inv' not fetchable due to <class 'requests.exceptions.SSLError'>: HTTPSConnectionPool(host='numba.pydata.org', port=443): Max retries exceeded with url: /numba-doc/latest/objects.inv (Caused by SSLError(CertificateError("hostname 'numba.pydata.org' doesn't match either of '*.github.com', 'www.github.com', 'github.io', 'github.com', '*.github.io', 'githubusercontent.com', '*.githubusercontent.com'")))

@andersy005
Copy link
Member

I opened an issue just in case this is something that can be fixed upstream.

@andersy005 andersy005 mentioned this pull request Aug 6, 2022
4 tasks
@andersy005 andersy005 enabled auto-merge (squash) August 6, 2022 01:04
@andersy005 andersy005 merged commit 9050a8b into pydata:main Aug 6, 2022
@andersy005
Copy link
Member

Thank you for this fix, @jrbourbeau!

@jrbourbeau jrbourbeau deleted the distributed-fixture-fixup branch August 6, 2022 01:29
@dcherian
Copy link
Contributor

dcherian commented Aug 8, 2022

Thanks @jrbourbeau!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants