Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework docs about scatter plots #7169

Merged
merged 4 commits into from
Oct 17, 2022
Merged

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Oct 16, 2022

Show off some more possibilities with the scatter plot.

@Illviljan Illviljan changed the title Rework docs about scatter Rework docs about scatter plots Oct 16, 2022
@Illviljan Illviljan marked this pull request as ready for review October 16, 2022 19:20
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do we want to showcase the DataArray version as well?

@Illviljan
Copy link
Contributor Author

Added one plot with the DataArray version now. Hopefully it's clear enough that the DataArray version works the same way as the dataset version.

@headtr1ck headtr1ck added plan to merge Final call for comments topic-documentation labels Oct 17, 2022
@Illviljan Illviljan merged commit a7f7190 into pydata:main Oct 17, 2022
dcherian added a commit to shoyer/xarray that referenced this pull request Oct 17, 2022
* main:
  Add import ASV benchmark (pydata#7176)
  Rework docs about scatter plots (pydata#7169)
  Fix some scatter plot issues (pydata#7167)
  Fix doctest warnings, enable errors in CI (pydata#7166)
  fix broken test (pydata#7168)
  Add typing to plot methods (pydata#7052)
  Fix warning in doctest (pydata#7165)
  dev whats-new (pydata#7161)
  v2022.10.0 whats-new (pydata#7160)
dcherian added a commit to JessicaS11/xarray that referenced this pull request Oct 17, 2022
* main:
  Add import ASV benchmark (pydata#7176)
  Rework docs about scatter plots (pydata#7169)
  Fix some scatter plot issues (pydata#7167)
  Fix doctest warnings, enable errors in CI (pydata#7166)
  fix broken test (pydata#7168)
  Add typing to plot methods (pydata#7052)
  Fix warning in doctest (pydata#7165)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants