Skip to content

Conversation

@keewis
Copy link
Collaborator

@keewis keewis commented Oct 25, 2022

I'm not sure if we actually need the dedicated "report" job, or whether adding an additional step to the main ci job would suffice?

I can see two reasons for a separate job:

  1. we get to control the python version independently from the version of the main job
  2. we upload the reportlog files as artifacts

I think if we can change the action to abort if it is run on a python version it does not support the first concern would not matter anymore, and for 2 we might just keep the "upload artifact" action (but is it even possible to manually access artifacts? If not we might not even need the upload).

Since I don't think either is a major concern, I went ahead and joined the jobs.

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Oct 25, 2022
@dcherian dcherian requested a review from andersy005 October 25, 2022 19:19
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍🏽... Thank you, @keewis!

@dcherian dcherian added the plan to merge Final call for comments label Oct 25, 2022
@keewis keewis enabled auto-merge (squash) October 26, 2022 08:46
@keewis keewis merged commit ca57e5c into pydata:main Oct 26, 2022
@keewis keewis deleted the issue-from-log-action branch October 26, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Automation Github bots, testing workflows, release automation plan to merge Final call for comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert upstream-dev CI scripts to github Action

3 participants