Accept rename to same name #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1223,7 +1223,8 @@ def rename(self, name_dict, inplace=False): | |||
| ---------- | |||
| name_dict : dict-like | |||
| Dictionary whose keys are current variable or dimension names and | |||
| whose values are new names. | |||
| whose values are new names (although the new name is permitted | |||
There was a problem hiding this comment.
Maybe it would be better to simple state "are desired names". It seems pretty logical that the same names would be OK.
|
Could you please add a brief note to what's new for 0.7.1? This should probably go under "enhancements" or "bug fixes". You'll need to create a new section |
|
Sure, will do all of these. |
|
Thanks! |
|
No problem. Sorry for the extra commit -- I tried to squash them together, but I'm new to rebase and apparently didn't do it right. Thanks for helping me incorporate this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #724