Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataArray.to_dask_dataframe() #7635
Implement DataArray.to_dask_dataframe() #7635
Changes from 21 commits
fe5e7ad
4174d50
ae32e83
ba47c16
924d2dd
3b9165c
ed559d3
65f9fab
bffe3cb
a7e423c
5c7a48f
43a8b9b
aff8eca
9e4f816
bcd06c8
4cca0a8
a2ee962
34a2ac5
8c50d1e
2c9ffb3
88f10bc
b19cd6f
1db928f
aa6c123
dd77cff
82bdd8e
a8500a2
75e20b4
65d3a93
69811fe
4bae82c
3d3b092
ee30fe4
9828442
6c2c5e3
71c0656
d89f8e0
7f3f9da
b545282
e733b0f
fd4501a
dffea4b
0ab7b16
6a31726
cb2feaa
40a3458
02f09d3
127db51
33d4960
5a2b24f
ee086a1
c732783
2e9cf38
38ebe32
ab619f9
e577a1c
d07a3c6
694ba77
53e9b4d
4866d8b
c563989
c2acb6f
87e993d
b60a226
4552d18
2466903
8bfbf3f
6eb67b3
1f67c6f
8b5c607
7c2e50c
8116bb1
e80ece0
dd58648
7ed49ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes .Please review them. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should raise an error for an unnamed DataArray.
This line is sticking a private xarray sentinel object in a user's DataFrame, it's going to cause issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made the changes as suggested . Please review them.