Improve to_dask_dataframe performance #7844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Illviljan
commented
May 15, 2023
•
Illviljan
commented
- ds.chunks loops all the variables, do it once.
- Faster to create a meta dataframe once than letting dask guess 2000 times.
dcherian
reviewed
May 18, 2023
xarray/core/dataset.py
Outdated
| @@ -6422,8 +6429,13 @@ def to_dask_dataframe( | |||
| if not is_duck_dask_array(var._data): | |||
| var = var.chunk() | |||
|
|
|||
| dask_array = var.set_dims(ordered_dims).chunk(self.chunks).data | |||
| series = dd.from_array(dask_array.reshape(-1), columns=[name]) | |||
| if has_many_dims: | |||
There was a problem hiding this comment.
Is this really that impactful, can we optimize set_dims instead?
There was a problem hiding this comment.
I'll think I'll save the has_many_dims paths for a future PR. I think it might introduce bugs if we don't consistently chunk with the same shape.
|
dcherian
approved these changes
May 24, 2023
19 tasks
dstansby
pushed a commit
to dstansby/xarray
that referenced
this pull request
Jun 28, 2023
* Improve to_dask_dataframe performance * Add ASV test * Update pandas.py * Update dataset.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.