Core team member guide #7999
Merged
Core team member guide #7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headtr1ck
approved these changes
Jul 18, 2023
|
Generally, this looks great, but can we adjust the language/title to emphasize "Core team member" rather than "Core developer" to be more inclusive? |
Co-authored-by: Michael Niklas <mick.niklas@gmail.com>
shoyer
reviewed
Jul 18, 2023
TomNicholas
commented
Jul 18, 2023
|
Okay I've addressed all the comments so far, reorganised, and included sections on issue triage from the pandas maintainers guide. |
3 tasks
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
😁
I agree, and I started by rewriting it as RST, but I got sick of reformatting the markdown copied from napari's docs so I decided to just leave that to a later PR. I think it's useful to concentrate on discussing the actual content of the guide in this PR too. |
jhamman
reviewed
Jul 20, 2023
There was a problem hiding this comment.
Thanks for writing this @TomNicholas! I left one comment but have an additional question. Should we put this in the documentation. There is some overlap here with the contribution guide. I wonder if this should be a page next to the broader guide.
|
Thanks @jhamman.
Yes there is definitely some overlap, and this should go in the main docs.
However I thought it was easier just to leave that reorganization for a
follow-up PR, and concentrate on the content in this PR, as Deepak and I
discussed above.
…On Wed, Jul 19, 2023, 8:04 PM Joe Hamman ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks for writing this @TomNicholas <https://github.com/TomNicholas>! I
left one comment but have an additional question. Should we put this in the
documentation. There is some overlap here with the contribution guide
<https://docs.xarray.dev/en/stable/contributing.html>. I wonder if this
should be a page next to the broader guide.
------------------------------
In CORE_TEAM_GUIDE.md
<#7999 (comment)>:
> + We prefer that usage questions are asked on StackOverflow with the pandas tag. https://stackoverflow.com/questions/tagged/pandas
+
+ If it’s easy to answer, feel free to link to the relevant documentation section, let them know that in the future this kind of question should be on StackOverflow, and close the issue.
⬇️ Suggested change
- We prefer that usage questions are asked on StackOverflow with the pandas tag. https://stackoverflow.com/questions/tagged/pandas
-
- If it’s easy to answer, feel free to link to the relevant documentation section, let them know that in the future this kind of question should be on StackOverflow, and close the issue.
+ We prefer that usage questions are asked on StackOverflow with the [`python-xarray` tag](https://stackoverflow.com/questions/tagged/python-xarray
+) or as a [GitHub discussion topic](https://github.com/pydata/xarray/discussions).
+
+ If it’s easy to answer, feel free to link to the relevant documentation section, let them know that in the future this kind of question should be on StackOverflow, and close the issue.
—
Reply to this email directly, view it on GitHub
<#7999 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AISNPI2QKNKSBMOO5SDMZATXRBYXRANCNFSM6AAAAAA2OSK24A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Co-authored-by: Joe Hamman <jhamman1@gmail.com>
for more information, see https://pre-commit.ci
… into core_dev_guide2
TomNicholas
commented
Jul 21, 2023
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jul 24, 2023
…lazy-array * upstream/main: (153 commits) Add HDF5 Section to read/write docs page (pydata#8012) [pre-commit.ci] pre-commit autoupdate (pydata#8014) Update interpolate_na in dataset.py (pydata#7974) improved docstring of to_netcdf (issue pydata#7127) (pydata#7947) Expose "Coordinates" as part of Xarray's public API (pydata#7368) Core team member guide (pydata#7999) join together duplicate entries in the text `repr` (pydata#7225) Update copyright year in README (pydata#8007) Allow opening datasets with nD dimenson coordinate variables. (pydata#7989) Move whats-new entry [pre-commit.ci] pre-commit autoupdate (pydata#7997) Add documentation on custom indexes (pydata#6975) Use variable name in all exceptions raised in `as_variable` (pydata#7995) Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 (pydata#7994) New whatsnew section Remove future release notes before this release Update whats-new.rst for new release (pydata#7993) Remove hue_style from plot1d docstring (pydata#7925) Add new what's new section (pydata#7986) Release summary for v2023.07.0 (pydata#7979) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a guide for core developers of xarray. Mostly adapted from napari's core dev guide, but with some extra sections and ideas from the pandas maintainance guide.
@pydata/xarray please give your feedback on this! If you prefer to give feedback in a non-public channel for whatever reason then please use the private core team email.
Closes #xxxxTests addedwhats-new.rstNew functions/methods are listed inapi.rst